lkml.org 
[lkml]   [2018]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] sched/fair: Avoid unnecessary balancing of asymmetric capacity groups
    On Thu, Feb 15, 2018 at 04:20:51PM +0000, Morten Rasmussen wrote:
    > +/*
    > + * group_similar_cpu_capacity: Returns true if the minimum capacity of the
    > + * compared groups differ by less than 12.5%.
    > + */
    > +static inline bool
    > +group_similar_cpu_capacity(struct sched_group *sg, struct sched_group *ref)
    > +{
    > + long diff = sg->sgc->min_capacity - ref->sgc->min_capacity;
    > + long max = max(sg->sgc->min_capacity, ref->sgc->min_capacity);
    > +
    > + return abs(diff) < max >> 3;
    > +}

    This seems a fairly random and dodgy heuristic.

    \
     
     \ /
      Last update: 2018-02-20 14:05    [W:2.450 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site