lkml.org 
[lkml]   [2018]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 54/67] staging: rtl8188eu: Fix incorrect response to SIOCGIWESSID
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Larry Finger <Larry.Finger@lwfinger.net>


    [ Upstream commit b77992d2df9e47144354d1b25328b180afa33442 ]

    When not associated with an AP, wifi device drivers should respond to the
    SIOCGIWESSID ioctl with a zero-length string for the SSID, which is the
    behavior expected by dhcpcd.

    Currently, this driver returns an error code (-1) from the ioctl call,
    which causes dhcpcd to assume that the device is not a wireless interface
    and therefore it fails to work correctly with it thereafter.

    This problem was reported and tested at
    https://github.com/lwfinger/rtl8188eu/issues/234.

    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 14 ++++----------
    1 file changed, 4 insertions(+), 10 deletions(-)

    --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
    +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
    @@ -1399,19 +1399,13 @@ static int rtw_wx_get_essid(struct net_d
    if ((check_fwstate(pmlmepriv, _FW_LINKED)) ||
    (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) {
    len = pcur_bss->Ssid.SsidLength;
    -
    - wrqu->essid.length = len;
    -
    memcpy(extra, pcur_bss->Ssid.Ssid, len);
    -
    - wrqu->essid.flags = 1;
    } else {
    - ret = -1;
    - goto exit;
    + len = 0;
    + *extra = 0;
    }
    -
    -exit:
    -
    + wrqu->essid.length = len;
    + wrqu->essid.flags = 1;

    return ret;
    }

    \
     
     \ /
      Last update: 2018-02-02 19:29    [W:4.077 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site