lkml.org 
[lkml]   [2018]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 44/67] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geert Uytterhoeven <geert+renesas@glider.be>


    [ Upstream commit 15bfe05c8d6386f1a90e9340d15336e85e32aad6 ]

    On 64-bit (e.g. powerpc64/allmodconfig):

    drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done':
    drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    dev_kfree_skb_irq((struct sk_buff *)cur_p->app4);
    ^

    cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer.

    Note that several other fields in struct cdmac_bd are also too small to
    hold physical addresses on 64-bit platforms.

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/xilinx/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/xilinx/Kconfig
    +++ b/drivers/net/ethernet/xilinx/Kconfig
    @@ -34,6 +34,7 @@ config XILINX_AXI_EMAC
    config XILINX_LL_TEMAC
    tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
    depends on (PPC || MICROBLAZE)
    + depends on !64BIT || BROKEN
    select PHYLIB
    ---help---
    This driver supports the Xilinx 10/100/1000 LocalLink TEMAC

    \
     
     \ /
      Last update: 2018-02-02 18:04    [W:5.457 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site