lkml.org 
[lkml]   [2018]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 11/20] firmware: arm_scmi: add support for polling based SCMI transfers
On Tue, Jan 2, 2018 at 3:42 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:

> +#define SCMI_MAX_POLLING_TIMEOUT_NS (100 * NSEC_PER_USEC)
> /**
> * scmi_do_xfer() - Do one transfer
> *
> @@ -389,14 +406,30 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer)

> + if (xfer->hdr.poll_completion) {
> + ktime_t stop, cur;
> +
> + stop = ktime_add_ns(ktime_get(), SCMI_MAX_POLLING_TIMEOUT_NS);
> + do {
> + udelay(5);
> + cur = ktime_get();
> + } while (!scmi_xfer_poll_done(info, xfer) &&
> + ktime_before(cur, stop));

The 5 microsecond back-off isn't that much smaller than the 100 microsecond
timeout, given that udelay() often waits much longer than the specified time.

How did you come up with those two numbers? Are you sure this is better
than just using a cpu_relax() instead of the udelay()?

Arnd

\
 
 \ /
  Last update: 2018-02-19 12:33    [W:0.355 / U:25.184 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site