lkml.org 
[lkml]   [2018]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 4/4] leaking_addresses: add scan_once array
Date
There are files under /proc that have the same format for each PID, e.g
'smaps'. We need only scan these files a single time to verify that
they are not leaking addresses. This reduces the work the script must
do.

Add once_only array.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
scripts/leaking_addresses.pl | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index f52e91ef7d5c..ab4e70d9efde 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -69,6 +69,12 @@ my @skip_any = (
'fd',
'usbmon');

+# These files are the same format under each PID that they appear.
+# We need only pass them once.
+my @once_only = (
+ 'smaps',
+ 'mb_groups');
+
sub help
{
my ($exitcode) = @_;
@@ -401,6 +407,25 @@ sub parse_dmesg
close $cmd;
}

+sub already_scanned
+{
+ my ($filename) = @_;
+ state %seen;
+
+ foreach (@once_only) {
+ if (/^$filename$/) {
+ if ($seen{$_} == 1) {
+ return 1;
+ }
+ $seen{$_} = 1;
+
+ return 0;
+ }
+ }
+
+ return 0;
+}
+
# True if we should skip this path.
sub skip
{
@@ -415,6 +440,10 @@ sub skip
return 1 if (/^$filename$/);
}

+ if (already_scanned($filename)) {
+ return 1;
+ }
+
return 0;
}

--
2.7.4
\
 
 \ /
  Last update: 2018-02-19 03:52    [W:0.207 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site