lkml.org 
[lkml]   [2018]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v3,05/11] watchdog/hpwdt: Update Module info.
    On Thu, Feb 15, 2018 at 04:43:54PM -0700, Jerry Hoemann wrote:
    > Update Module Author and description to reflect changes in driver.
    >
    > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
    > ---
    > drivers/watchdog/hpwdt.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
    > index d5989acf3e37..71e49d0ab789 100644
    > --- a/drivers/watchdog/hpwdt.c
    > +++ b/drivers/watchdog/hpwdt.c
    > @@ -425,8 +425,8 @@ static struct pci_driver hpwdt_driver = {
    > .remove = hpwdt_exit,
    > };
    >
    > -MODULE_AUTHOR("Tom Mingarelli");
    > -MODULE_DESCRIPTION("hp watchdog driver");
    > +MODULE_AUTHOR("Jerry Hoemann");
    > +MODULE_DESCRIPTION("hpe watchdog driver");

    It is quite unusual to replace an author name. The original author is
    still the original author and should be retained. Adding another author
    is fine, but I disagree with the removal.

    Guenter

    > MODULE_LICENSE("GPL");
    > MODULE_VERSION(HPWDT_VERSION);
    >

    \
     
     \ /
      Last update: 2018-02-17 17:19    [W:4.570 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site