lkml.org 
[lkml]   [2018]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4] rtc: isl12026: Add driver.
On Fri, Feb 16, 2018 at 11:19 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> On 02/16/2018 12:13 PM, Andy Shevchenko wrote:
>> On Fri, Feb 16, 2018 at 9:44 PM, David Daney <david.daney@cavium.com>
>> wrote:

>>> +config RTC_DRV_ISL12026
>>> + tristate "Intersil ISL12026"

>> depends on OF

> It doesn't depend on CONFIG_OF, it builds just fine without it.

OK.
But then it's useless.

depends on OF || COMPILE_TEST

>>> +static struct i2c_driver isl12026_driver = {
>>> + .driver = {
>>> + .name = "rtc-isl12026",
>>> + .of_match_table = of_match_ptr(isl12026_dt_match),

>> /of_match_ptr//

> of_match_ptr() needed if we build without CONFIG_OF

OK.
Have you tried to enable warnings?
You must get `defined but not used` one.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-02-16 22:25    [W:3.037 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site