Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 16 Feb 2018 23:24:53 +0200 | Subject | Re: [PATCH v4] rtc: isl12026: Add driver. |
| |
On Fri, Feb 16, 2018 at 11:19 PM, David Daney <ddaney@caviumnetworks.com> wrote: > On 02/16/2018 12:13 PM, Andy Shevchenko wrote: >> On Fri, Feb 16, 2018 at 9:44 PM, David Daney <david.daney@cavium.com> >> wrote:
>>> +config RTC_DRV_ISL12026 >>> + tristate "Intersil ISL12026"
>> depends on OF
> It doesn't depend on CONFIG_OF, it builds just fine without it.
OK. But then it's useless.
depends on OF || COMPILE_TEST
>>> +static struct i2c_driver isl12026_driver = { >>> + .driver = { >>> + .name = "rtc-isl12026", >>> + .of_match_table = of_match_ptr(isl12026_dt_match),
>> /of_match_ptr//
> of_match_ptr() needed if we build without CONFIG_OF
OK. Have you tried to enable warnings? You must get `defined but not used` one.
-- With Best Regards, Andy Shevchenko
| |