lkml.org 
[lkml]   [2018]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/15] soc: renesas: Add R-Car M3-N support
On Wed, Feb 14, 2018 at 01:48:27PM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> Thanks for your patch!
>
> On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
> <jacopo+renesas@jmondi.org> wrote:
> > Add support for R-Car M3-N (r8a77965) power areas and reset.
> > M3-N power areas are identical to M3-W ones, so just copy and rename
> > them.
>
> They are not identical:
> - M3-N does not have the CA53-related areas,
> - M3-W does not have A3VP,
> - M3-N does not have A2VC0 (M3-W also doesn't, according to latest
> datasheet?).
>
> The datasheet also mentions A3SH, without further info about the register
> block. I think we need to bring this up with Renesas.
>
> > .../bindings/power/renesas,rcar-sysc.txt | 1 +
> > .../devicetree/bindings/reset/renesas,rst.txt | 1 +
> > drivers/soc/renesas/Kconfig | 9 ++++--
> > drivers/soc/renesas/Makefile | 1 +
> > drivers/soc/renesas/r8a77965-sysc.c | 37 ++++++++++++++++++++++
> > drivers/soc/renesas/rcar-rst.c | 1 +
> > drivers/soc/renesas/rcar-sysc.c | 3 ++
> > drivers/soc/renesas/rcar-sysc.h | 1 +
> > drivers/soc/renesas/renesas-soc.c | 8 +++++
> > include/dt-bindings/power/r8a77965-sysc.h | 31 ++++++++++++++++++
> > 10 files changed, 91 insertions(+), 2 deletions(-)
> > create mode 100644 drivers/soc/renesas/r8a77965-sysc.c
> > create mode 100644 include/dt-bindings/power/r8a77965-sysc.h
>
> The maintainer may ask you to split this patch by functionality...

Yes, I would like this split up.

I think "[PATCH 00/11] Add R8A77980/Condor board support" provides
a good example.

\
 
 \ /
  Last update: 2018-02-15 18:26    [W:0.101 / U:16.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site