Messages in this thread | | | Subject | Re: [PATCH] drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR | From | "Gustavo A. R. Silva" <> | Date | Thu, 15 Feb 2018 10:09:09 -0600 |
| |
On 02/15/2018 03:13 AM, Jani Nikula wrote: > On Wed, 14 Feb 2018, "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote: >> Fix inconsistent IS_ERR and PTR_ERR in shrink_boom. >> The proper pointer to use is _explode_ instead of _purge_. >> >> This issue was detected with the help of Coccinelle. >> >> Fixes: fe215c8bc426 ("drm/i915/selftests: add missing gtt shrinker test") >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > (Having some issues with fdo connections, thus not pushing.) >
Thanks, Jani -- Gustavo
>> --- >> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> index d806427..89b6ca9 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c >> @@ -927,7 +927,7 @@ static int shrink_boom(struct drm_i915_private *i915, >> >> explode = fake_dma_object(i915, size); >> if (IS_ERR(explode)) { >> - err = PTR_ERR(purge); >> + err = PTR_ERR(explode); >> goto err_purge; >> } >
| |