lkml.org 
[lkml]   [2018]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v13 7/9] ACPI: Translate the I/O range of non-MMIO devices before scanning
From
Date
On 15/02/2018 12:22, Andy Shevchenko wrote:
> On Thu, Feb 15, 2018 at 1:19 PM, John Garry <john.garry@huawei.com> wrote:
>

Hi Andy,

>> +static const struct acpi_device_id indirect_io_hosts[] = {
>> + {"HISI0191", 0}, /* HiSilicon LPC host */
>> + {},
>
> Just a nit.
>

I noticed that I have this in the LLDD also. I think that this may be a
force of habit.

> It seems lately this happens more often than usual, I mean a comma in
> the terminator line.
>
> If we remove it. we terminate not only at runtime, but at compile
> time, which is slightly better.

I grepped for "{}," in the drivers folder and it gives many results (I
do accept that some are not sentinels):
>grep -R "{}," * | tail
watchdog/gef_wdt.c: {},
watchdog/asm9260_wdt.c: {},
watchdog/bcm2835_wdt.c: {},
watchdog/digicolor_wdt.c: {},
watchdog/bcm7038_wdt.c: {},
watchdog/ath79_wdt.c: {},
watchdog/riowd.c: {},
watchdog/sbsa_gwdt.c: {},
watchdog/sbsa_gwdt.c: {},
watchdog/bcm_kona_wdt.c: {},

Much appreciated,
John


\
 
 \ /
  Last update: 2018-02-15 13:53    [W:0.073 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site