Messages in this thread | | | From | Alan Tull <> | Date | Wed, 14 Feb 2018 09:55:15 -0600 | Subject | Re: [PATCH v4 03/24] fpga: mgr: add status for fpga-manager |
| |
On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao <hao.wu@intel.com> wrote:
Hi Hao,
> This patch adds status to fpga-manager data structure,
Please update the header to better describe the current changes, this patch no longer adds status to the fpga mgr data struct.
> to allow > driver to store full/partial reconfiguration errors and other > status information, and adds one status callback to fpga_manager_ops > to allow fpga_manager to collect latest status when failures are > detected.
Other than that, looks good to me! Thanks for taking my feedback. Alan
> > The following sysfs file is created: > * /sys/class/fpga_manager/<fpga>/status > Return status of fpga manager, including reconfiguration errors. > > Signed-off-by: Wu Hao <hao.wu@intel.com> Acked-by: Alan Tull <atull@kernel.org>
| |