Messages in this thread | | | Date | Wed, 14 Feb 2018 13:59:43 +0000 | From | James Hogan <> | Subject | Re: [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0 |
| |
On Wed, Feb 14, 2018 at 11:35:44AM +0100, Mathieu Malaterre wrote: > On Tue, Jan 2, 2018 at 7:55 PM, Mathieu Malaterre <malat@debian.org> wrote: > > Hi James, > > > > On Tue, Jan 2, 2018 at 10:31 AM, James Hogan <james.hogan@mips.com> wrote: > >> On Tue, Dec 26, 2017 at 12:37:14PM +0100, Mathieu Malaterre wrote: > >>> Rewrite the comparison in `else if` statement, case where `min_low_pfn > > >>> ARCH_PFN_OFFSET` has already been checked in the first `if` statement: > >>> > >>> if (min_low_pfn > ARCH_PFN_OFFSET) { > >>> > >>> Fix non-fatal warning: > >>> > >>> arch/mips/kernel/setup.c: In function ‘bootmem_init’: > >>> arch/mips/kernel/setup.c:461:25: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > >>> } else if (min_low_pfn < ARCH_PFN_OFFSET) { > >>> ^ > >> > >> What compiler version is that with out of interest? It isn't exactly new > >> code. > > > > I've clarified in v2, that this happen during compilation using W=1 > > > > For reference: > > > > $ mipsel-linux-gnu-gcc -dumpversion > > 6.3.0 > > > > > >>> > >>> Signed-off-by: Mathieu Malaterre <malat@debian.org> > >> > >> Reviewed-by: James Hogan <jhogan@kernel.org> > > > > Thanks ! > > ping ? > > https://patchwork.linux-mips.org/project/linux-mips/list/?series=623
Yep, both applied for 4.17.
Thanks James [unhandled content-type:application/pgp-signature] | |