lkml.org 
[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 03/11] watchdog/hpwdt: Update nmi_panic message.
On Tue, Feb 13, 2018 at 09:41:35AM -0800, Guenter Roeck wrote:
> On Sun, Feb 11, 2018 at 10:21:03PM -0700, Jerry Hoemann wrote:
> > + unsigned int mynmi = hpwdt_my_nmi();
> > + static char panic_msg[] =
> > + "00: An NMI occurred. Depending on your system the reason "
> > + "for the NMI is logged in any one of the following resources:\n"
> > + "1. Integrated Management Log (IML)\n"
> > + "2. OA Syslog\n"
> > + "3. OA Forward Progress Log\n"
> > + "4. iLO Event Log";
> > +
> > + if ((ulReason == NMI_UNKNOWN) && !mynmi)
> > return NMI_DONE;
> >
> > if (allow_kdump)
> > hpwdt_stop();
> >
> > - nmi_panic(regs, "An NMI occurred. Depending on your system the reason "
> > - "for the NMI is logged in any one of the following "
> > - "resources:\n"
> > - "1. Integrated Management Log (IML)\n"
> > - "2. OA Syslog\n"
> > - "3. OA Forward Progress Log\n"
> > - "4. iLO Event Log");
> > + panic_msg[0] = hexdigit((mynmi>>4)&0xf);
> > + panic_msg[1] = hexdigit(mynmi&0xf);
>
> No need to reinvent the wheel.
>
> panic_msg[0] = hex_asc_hi(mynmi);
> panic_msg[1] = hex_asc_lo(mynmi);
>
> or even better
> hex_byte_pack(panic_msg, mynmi);
>
> There are matching _upper functions if you prefer A..F instead of a..f.
>
> Guenter

Will do. thanks

--

-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-----------------------------------------------------------------------------

\
 
 \ /
  Last update: 2018-02-13 23:01    [W:0.114 / U:5.112 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site