lkml.org 
[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 0/2] Add support for AK4458 DAC
On Tue, Feb 13, 2018 at 4:14 PM, Cosmin-Gabriel Samoila
<cosmin.samoila@nxp.com> wrote:
> We support Normal Mode, TDM Mode and PM.
>

Read the comments Mark and me gave against another [1] submission.

[1]: https://www.spinics.net/lists/alsa-devel/msg73471.html

> Changes since V1:
> - support only i2c
> - i2c probe / remove/suspend/ resume moved into shared code
> - change enum array to separate variables
> - aggregate Volume control for Left and Right Channel
> - remove mux from DAPM
> - remove unused functions
> - remove unused controls
> - remove unused macros
> - use snd_soc_update_bits instead of soc_read + soc_write
> - use GPIOD
> - use SPDX identifier
> - use dac@10 instgitead of ak4458@10
> - use explicit power_on/off functions
> - add __maybe_unused attribute
> - use probe_new for i2c_probe
>
> Cosmin-Gabriel Samoila (2):
> ASoC: codecs: Add support for AK4458 DAC driver
> ASoC: ak4458: Add bindings for AK4458 DAC
>
> Documentation/devicetree/bindings/sound/ak4458.txt | 23 +
> sound/soc/codecs/Kconfig | 6 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/ak4458.c | 684 +++++++++++++++++++++
> sound/soc/codecs/ak4458.h | 75 +++
> 5 files changed, 790 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt
> create mode 100644 sound/soc/codecs/ak4458.c
> create mode 100644 sound/soc/codecs/ak4458.h
>
> --
> 2.7.4
>



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-02-13 19:33    [W:0.038 / U:0.132 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site