[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] perf tests: Use arch__compare_symbol_names to compare symbols
The symbol search called by machine__find_kernel_symbol_by_name
is using internally arch__compare_symbol_names function to compare
2 symbol names, because different archs have different ways of
comparing symbols. Mostly for skipping '.' prefixes and similar.

In test 1 when we try to find matching symbols in kallsyms and
vmlinux, by address and by symbol name. When either is found
we compare the pair symbol names by simple strcmp, which is not
good enough for reasons explained in previous paragraph.

On powerpc this can cause lockup, because even thought we found
the pair, the compared names are different and don't match
simple strcmp. Following code path is executed, that leads
to lockup:

- we find the pair in kallsyms by sym->start
- we compare the names and it fails
- we find the pair by sym->name
- the pair addresses match so we call goto next_pair
because we assume the names match in this case

Signed-off-by: Jiri Olsa <>
tools/perf/tests/vmlinux-kallsyms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/vmlinux-kallsyms.c b/tools/perf/tests/vmlinux-kallsyms.c
index 58349297f9fb..1e5adb65632a 100644
--- a/tools/perf/tests/vmlinux-kallsyms.c
+++ b/tools/perf/tests/vmlinux-kallsyms.c
@@ -125,7 +125,7 @@ int test__vmlinux_matches_kallsyms(struct test *test __maybe_unused, int subtest

if (pair && UM(pair->start) == mem_start) {
- if (strcmp(sym->name, pair->name) == 0) {
+ if (arch__compare_symbol_names(sym->name, pair->name) == 0) {
* kallsyms don't have the symbol end, so we
* set that by using the next symbol start - 1,
 \ /
  Last update: 2018-02-13 14:39    [W:0.020 / U:0.668 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site