Messages in this thread | | | Date | Tue, 13 Feb 2018 11:30:13 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH] Revert "ARM: dts: sunxi: Add regulators for Sinovoip BPI-M2" |
| |
On Fri, Feb 09, 2018 at 10:20:57PM +0100, Emmanuel Vadot wrote: > > P.S. a proper device tree with AXP shouldn't use > > reg_vcc3v0/3v3/1v8/etc. They're dummy > > regulator nodes for > > not implemented or not controllable regulators. > > > > > > > > > This indicates that this patch should be not tested at all. > > > > > > This have indeed not been tested with linux. > > > I think that this commit should not be reverted, I'll send a proper > > > patch tonight or tomorow night max. > > > > Please test patches sent to Linux on Linux :-) > > If my patches adhere to the bindings I don't see why.
Adhering to a binding and being functional is a completely different story.
And the latter is the most important.
Maxime
-- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com [unhandled content-type:application/pgp-signature] | |