Messages in this thread | | | From | Balbir Singh <> | Date | Tue, 13 Feb 2018 10:01:57 +1100 | Subject | Re: [PATCH 1/2] powerpc/kdump: Add missing optional dummy functions |
| |
On Tue, Feb 13, 2018 at 9:34 AM, Guenter Roeck <linux@roeck-us.net> wrote: > If KEXEC_CORE is not enabled, PowerNV builds fail as follows. > > arch/powerpc/platforms/powernv/smp.c: In function 'pnv_smp_cpu_kill_self': > arch/powerpc/platforms/powernv/smp.c:236:4: error: > implicit declaration of function 'crash_ipi_callback' > > Add dummy function calls, similar to kdump_in_progress(), to solve the > problem. > > Fixes: 4145f358644b ("powernv/kdump: Fix cases where the kdump kernel ...") > Cc: Balbir Singh <bsingharora@gmail.com> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Nicholas Piggin <npiggin@gmail.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > ---
Thanks for working on this.
You've added two functions, I understand the crash_send_ipi() bits that I broke. Looks like crash_ipi_callback broken without KEXEC_CORE?
I am going to test these patches, for now
Acked-by: Balbir Singh <bsingharora@gmail.com>
Balbir Singh
| |