Messages in this thread | | | Date | Mon, 12 Feb 2018 19:17:31 +0100 | From | Juri Lelli <> | Subject | Re: [RFC PATCH 1/3] sched/deadline: merge dl_bw into dl_bandwidth |
| |
On 12/02/18 13:02, Steven Rostedt wrote: > On Mon, 12 Feb 2018 18:43:12 +0100 > Juri Lelli <juri.lelli@redhat.com> wrote: > > > However, this surely needs to be fixed here. It's tracking the sum of > > all tasks' (across CPUs) bandwidth admitted on the system, so that's why > > it's called dl_total_bw. Incremented when a task passes sched_setattr() > > and decremented when it leaves the system or changes scheduling class. > > > > Does it make a bit more sense? Would you still prefer a different name? > > No the name is fine, the comment needs to change. > > - dl_total_bw - tracks the sum of all tasks' bandwidth across CPUs. > > How's that?
LGTM. I'll fix in next version.
Thanks!
- Juri
| |