lkml.org 
[lkml]   [2018]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.16 002/136] staging: lustre: ptlrpc: kfree used instead of kvfree

> 3.16.54-rc1 review patch. If anyone has any objections, please let me know.

Reviewed-by: James Simmons <jsimmons@infradead.org>

> ------------------
>
> From: Nadav Amit <namit@vmware.com>
>
> commit c3eec59659cf25916647d2178c541302bb4822ad upstream.
>
> rq_reqbuf is allocated using kvmalloc() but released in one occasion
> using kfree() instead of kvfree().
>
> The issue was found using grep based on a similar bug.
>
> Fixes: d7e09d0397e8 ("add Lustre file system client support")
> Fixes: ee0ec1946ec2 ("lustre: ptlrpc: Replace uses of OBD_{ALLOC,FREE}_LARGE")
>
> Cc: Peng Tao <bergwolf@gmail.com>
> Cc: Oleg Drokin <oleg.drokin@intel.com>
> Cc: James Simmons <jsimmons@infradead.org>
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> [bwh: Backported to 3.16: use OBD_FREE_LARGE()]
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/staging/lustre/lustre/ptlrpc/sec.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/sec.c
> @@ -867,7 +867,7 @@ void sptlrpc_request_out_callback(struct
> if (req->rq_pool || !req->rq_reqbuf)
> return;
>
> - OBD_FREE(req->rq_reqbuf, req->rq_reqbuf_len);
> + OBD_FREE_LARGE(req->rq_reqbuf, req->rq_reqbuf_len);
> req->rq_reqbuf = NULL;
> req->rq_reqbuf_len = 0;
> }
>
>

\
 
 \ /
  Last update: 2018-02-11 22:36    [W:0.631 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site