lkml.org 
[lkml]   [2018]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 01/79] Input: adxl34x - do not treat FIFO_MODE() as boolean
    3.2.99-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit 1dbc080c9ef6bcfba652ef0d6ae919b8c7c85a1d upstream.

    FIFO_MODE() is a macro expression with a '<<' operator, which gcc points
    out could be misread as a '<':

    drivers/input/misc/adxl34x.c: In function 'adxl34x_probe':
    drivers/input/misc/adxl34x.c:799:36: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]

    While utility of this warning is being disputed (Chief Penguin: "This
    warning is clearly pure garbage.") FIFO_MODE() extracts range of values,
    with 0 being FIFO_BYPASS, and not something that is logically boolean.

    This converts the test to an explicit comparison with FIFO_BYPASS,
    making it clearer to gcc and the reader what is intended.

    Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/input/misc/adxl34x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/input/misc/adxl34x.c
    +++ b/drivers/input/misc/adxl34x.c
    @@ -797,7 +797,7 @@ struct adxl34x *adxl34x_probe(struct dev

    if (pdata->watermark) {
    ac->int_mask |= WATERMARK;
    - if (!FIFO_MODE(pdata->fifo_mode))
    + if (FIFO_MODE(pdata->fifo_mode) == FIFO_BYPASS)
    ac->pdata.fifo_mode |= FIFO_STREAM;
    } else {
    ac->int_mask |= DATA_READY;
    \
     
     \ /
      Last update: 2018-02-11 06:25    [W:4.308 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site