lkml.org 
[lkml]   [2018]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 07/79] media: rc: check for integer overflow
    3.2.99-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sean Young <sean@mess.org>

    commit 3e45067f94bbd61dec0619b1c32744eb0de480c8 upstream.

    The ioctl LIRC_SET_REC_TIMEOUT would set a timeout of 704ns if called
    with a timeout of 4294968us.

    Signed-off-by: Sean Young <sean@mess.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    [bwh: Backported to 3.2: open-code U32_MAX]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/media/rc/ir-lirc-codec.c | 9 ++++++---
    1 file changed, 6 insertions(+), 3 deletions(-)

    --- a/drivers/media/rc/ir-lirc-codec.c
    +++ b/drivers/media/rc/ir-lirc-codec.c
    @@ -255,11 +255,14 @@ static long ir_lirc_ioctl(struct file *f
    if (!dev->max_timeout)
    return -ENOSYS;

    + /* Check for multiply overflow */
    + if (val > (u32)(-1) / 1000)
    + return -EINVAL;
    +
    tmp = val * 1000;

    - if (tmp < dev->min_timeout ||
    - tmp > dev->max_timeout)
    - return -EINVAL;
    + if (tmp < dev->min_timeout || tmp > dev->max_timeout)
    + return -EINVAL;

    dev->timeout = tmp;
    break;
    \
     
     \ /
      Last update: 2018-02-11 05:34    [W:4.119 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site