Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 10 Feb 2018 14:19:04 -0800 | Subject | Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config |
| |
Looks good to me.
At the risk of bike-shedding, we could remove all the
default 1 if !SMP
from the BEGIN/END/DEFAULT things, and perhaps just keep that part in NR_CPUS.
I didn't check, but I *think* it would work to just do
config NR_CPUS int "Maximum number of CPUs" if SMP && !MAXSMP range NR_CPUS_RANGE_BEGIN NR_CPUS_RANGE_END default "1" if !SMP default NR_CPUS_DEFAULT
but maybe the "range" line would need an "if !SMP" on it too to avoid the issue with "1" being out of range.,
That would still leave the NR_CPUS thing *much* easier to understand, and it would mean that the other helper things wouldn't need to care about the UP case.
But regardless, that least version looks perfectly fine to me even without that random tweak.
Linus
| |