lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 020/328] leds: max8997: use mode when calling max8997_led_set_mode
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit 7a5de56db902ea632a0ff0c2b47481d278db645f upstream.

    Variable mode is assigned to pdata->led_pdata->mode[led->id] and yet
    is not being used when calling function max8997_led_set_mode. Fix
    this by using mode when calling max8997_led_set_mode.

    Cleans up clang warning:
    warning: variable 'mode' set but not used [-Wunused-but-set-variable]

    Fixes: 8584cb82f151 ("leds: Add suuport for MAX8997-LED driver")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/leds/leds-max8997.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/leds/leds-max8997.c
    +++ b/drivers/leds/leds-max8997.c
    @@ -262,7 +262,7 @@ static int max8997_led_probe(struct plat
    mode = pdata->led_pdata->mode[led->id];
    brightness = pdata->led_pdata->brightness[led->id];

    - max8997_led_set_mode(led, pdata->led_pdata->mode[led->id]);
    + max8997_led_set_mode(led, mode);

    if (brightness > led->cdev.max_brightness)
    brightness = led->cdev.max_brightness;
    \
     
     \ /
      Last update: 2018-12-09 23:28    [W:5.293 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site