lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 160/328] cifs: check kmalloc before use
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nicholas Mc Guire <hofrat@osadl.org>

    commit 126c97f4d0d1b5b956e8b0740c81a2b2a2ae548c upstream.

    The kmalloc was not being checked - if it fails issue a warning
    and return -ENOMEM to the caller.

    Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
    Fixes: b8da344b74c8 ("cifs: dynamic allocation of ntlmssp blob")
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/sess.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/fs/cifs/sess.c
    +++ b/fs/cifs/sess.c
    @@ -398,6 +398,12 @@ int build_ntlmssp_auth_blob(unsigned cha
    goto setup_ntlmv2_ret;
    }
    *pbuffer = kmalloc(size_of_ntlmssp_blob(ses), GFP_KERNEL);
    + if (!*pbuffer) {
    + rc = -ENOMEM;
    + cifs_dbg(VFS, "Error %d during NTLMSSP allocation\n", rc);
    + *buflen = 0;
    + goto setup_ntlmv2_ret;
    + }
    sec_blob = (AUTHENTICATE_MESSAGE *)*pbuffer;

    memcpy(sec_blob->Signature, NTLMSSP_SIGNATURE, 8);
    \
     
     \ /
      Last update: 2018-12-09 23:25    [W:4.087 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site