lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 240/328] ext4: don't mark mmp buffer head dirty
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Li Dongyang <dongyangli@ddn.com>

    commit fe18d649891d813964d3aaeebad873f281627fbc upstream.

    Marking mmp bh dirty before writing it will make writeback
    pick up mmp block later and submit a write, we don't want the
    duplicate write as kmmpd thread should have full control of
    reading and writing the mmp block.
    Another reason is we will also have random I/O error on
    the writeback request when blk integrity is enabled, because
    kmmpd could modify the content of the mmp block(e.g. setting
    new seq and time) while the mmp block is under I/O requested
    by writeback.

    Signed-off-by: Li Dongyang <dongyangli@ddn.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Reviewed-by: Andreas Dilger <adilger@dilger.ca>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/ext4/mmp.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/fs/ext4/mmp.c
    +++ b/fs/ext4/mmp.c
    @@ -48,7 +48,6 @@ static int write_mmp_block(struct super_
    */
    sb_start_write(sb);
    ext4_mmp_csum_set(sb, mmp);
    - mark_buffer_dirty(bh);
    lock_buffer(bh);
    bh->b_end_io = end_buffer_write_sync;
    get_bh(bh);
    \
     
     \ /
      Last update: 2018-12-09 23:23    [W:5.225 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site