lkml.org 
[lkml]   [2018]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm, kmemleak: Little optimization while scanning
From
Date

> > +
>
> This one maybe not necessary.

Yeah, that is a remind of an include file I used for time measurement.
I hope Andrew can drop that if this is taken.

> > /*
> > * Kmemleak configuration and common defines.
> > */
> > @@ -1547,11 +1548,14 @@ static void kmemleak_scan(void)
> > unsigned long pfn;
> >
> > for (pfn = start_pfn; pfn < end_pfn; pfn++) {
> > - struct page *page;
> > + struct page *page =
> > pfn_to_online_page(pfn);
> > +
> > + if (!page)
> > + continue;
> >
> > - if (!pfn_valid(pfn))
> > + /* only scan pages belonging to this node
> > */
> > + if (page_to_nid(page) != i)
> > continue;
>
> Not farmiliar with this situation. Is this often?
Well, hard to tell how often that happens because that mostly depends
on the Hardware in case of baremetal.
Virtual systems can also have it though.

>
> > - page = pfn_to_page(pfn);
> > /* only scan if page is in use */
> > if (page_count(page) == 0)
> > continue;
> > --
> > 2.13.7
>
>
--
Oscar Salvador
SUSE L3

\
 
 \ /
  Last update: 2018-12-07 07:15    [W:0.030 / U:3.496 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site