Messages in this thread | | | Date | Fri, 7 Dec 2018 10:21:56 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2 07/17] debugobjects: Move printk out of db lock critical sections |
| |
On Mon, Nov 19, 2018 at 01:55:16PM -0500, Waiman Long wrote: > The db->lock is a raw spinlock and so the lock hold time is supposed > to be short. This will not be the case when printk() is being involved > in some of the critical sections. In order to avoid the long hold time, > in case some messages need to be printed, the debug_object_is_on_stack() > and debug_print_object() calls are now moved out of those critical > sections.
That's not why you did this patch though; you want to make these locks terminal locks and that means no printk() inside, as that uses locks again.
Please write relevant changelogs.
| |