lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 13/55] iser: set sector for ambiguous mr status errors
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sagi Grimberg <sagi@grimberg.me>

    commit 24c3456c8d5ee6fc1933ca40f7b4406130682668 upstream.

    If for some reason we failed to query the mr status, we need to make sure
    to provide sufficient information for an ambiguous error (guard error on
    sector 0).

    Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection")
    Cc: <stable@vger.kernel.org>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/ulp/iser/iser_verbs.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    --- a/drivers/infiniband/ulp/iser/iser_verbs.c
    +++ b/drivers/infiniband/ulp/iser/iser_verbs.c
    @@ -1108,7 +1108,9 @@ u8 iser_check_task_pi_status(struct iscs
    IB_MR_CHECK_SIG_STATUS, &mr_status);
    if (ret) {
    pr_err("ib_check_mr_status failed, ret %d\n", ret);
    - goto err;
    + /* Not a lot we can do, return ambiguous guard error */
    + *sector = 0;
    + return 0x1;
    }

    if (mr_status.fail_status & IB_MR_CHECK_SIG_STATUS) {
    @@ -1136,9 +1138,6 @@ u8 iser_check_task_pi_status(struct iscs
    }

    return 0;
    -err:
    - /* Not alot we can do here, return ambiguous guard error */
    - return 0x1;
    }

    void iser_err_comp(struct ib_wc *wc, const char *type)

    \
     
     \ /
      Last update: 2018-12-06 15:58    [W:2.142 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site