lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Spice-devel] [PATCH] drm/qxl: use qxl_num_crtc directly
> 
> On Thu, Dec 06, 2018 at 05:59:25AM -0500, Frediano Ziglio wrote:
> > >
> > > Just use qxl_num_crtc directly everywhere instead of using
> > > qdev->monitors_config->max_allowed. Drops pointless indirection
> > > and also is less confusing.
> > >
> >
> > To me is MORE confusing, why comparing number of something with
> > another number? Previously code was comparing number of monitors
> > with number of monitors, not number of CRTs with number of
> > monitors.
>
> Yes, spice/qxl and drm/kms use slightly different terminology.
>
> drm crtc == qxl monitor.
> drm framebuffer == qxl surface.
>
> You need to know that anyway when looking at the qxl ksm code. We
> have function names like qxl_crtc_update_monitors_config(). I fail
> to see why that is a problem ...
>
> cheers,
> Gerd
>
>

I don't see any problem too but you are explaining to me
why your rationale "and also is less confusing" does not
stand.

Frediano

\
 
 \ /
  Last update: 2018-12-06 13:53    [W:0.054 / U:13.852 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site