lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/15 v4] regulator: lm363x: Let core handle GPIO descriptor
    Date
    Use the gpiod_get() rather than the devm_* version so that the
    regulator core can handle the lifecycle of these descriptors.

    Fixes: b2d751b7f69b ("regulator: lm363x: Pass descriptor instead of GPIO number")
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    ---
    ChangeLog v3->v4:
    - Resending.
    ChangeLog v2->v3:
    - Resending.
    ChangeLog v1->v2:
    - Drop the gpiod_put() on the errorpath after devm_regulator_register()
    as this will be handled by the regulator core.
    - Put a comment in the code so maintainers knows not to
    use managed resources (devm*)
    ---
    drivers/regulator/lm363x-regulator.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c
    index bbedb08d257b..8c0e8419c43f 100644
    --- a/drivers/regulator/lm363x-regulator.c
    +++ b/drivers/regulator/lm363x-regulator.c
    @@ -224,13 +224,15 @@ static struct gpio_desc *lm363x_regulator_of_get_enable_gpio(struct device *dev,
    /*
    * Check LCM_EN1/2_GPIO is configured.
    * Those pins are used for enabling VPOS/VNEG LDOs.
    + * Do not use devm* here: the regulator core takes over the
    + * lifecycle management of the GPIO descriptor.
    */
    switch (id) {
    case LM3632_LDO_POS:
    - return devm_gpiod_get_index_optional(dev, "enable", 0,
    + return gpiod_get_index_optional(dev, "enable", 0,
    GPIOD_OUT_LOW | GPIOD_FLAGS_BIT_NONEXCLUSIVE);
    case LM3632_LDO_NEG:
    - return devm_gpiod_get_index_optional(dev, "enable", 1,
    + return gpiod_get_index_optional(dev, "enable", 1,
    GPIOD_OUT_LOW | GPIOD_FLAGS_BIT_NONEXCLUSIVE);
    default:
    return NULL;
    @@ -263,6 +265,8 @@ static int lm363x_regulator_probe(struct platform_device *pdev)
    LM3632_EXT_EN_MASK,
    LM3632_EXT_EN_MASK);
    if (ret) {
    + if (gpiod)
    + gpiod_put(gpiod);
    dev_err(dev, "External pin err: %d\n", ret);
    return ret;
    }
    --
    2.19.2
    \
     
     \ /
      Last update: 2018-12-06 13:44    [W:2.611 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site