lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] drm/ttm: Use pr_debug for all output from ttm_bo_evict
Date
Am 06.12.18 um 10:09 schrieb Michel Dänzer:
> On 2018-12-06 3:43 a.m., Zhang, Jerry(Junwei) wrote:
>> On 12/6/18 12:56 AM, Michel Dänzer wrote:
>>> From: Michel Dänzer <michel.daenzer@amd.com>
>>>
>>> All the output is related, so it should all be printed the same way.
>>> Some of it was using pr_debug, but some of it appeared in dmesg by
>>> default. The caller should handle failure, so there's no need to spam
>>> dmesg with potentially quite a lot of output by default.
>>>
>>> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
>> Sounds reasonable, but personally prefer to show error when some
>> vital incident happens, e.g. no memory on eviction.
> The amdgpu driver still prints these in that case:
>
> [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* amdgpu_cs_list_validate(validated) failed.
> [drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Not enough memory for command submission!
>
> That's plenty as far as I'm concerned. :)

Yeah, but in this case I would rather make the amdgpu messages debug
level and leave the TTM meassages on error level.

Christian.
\
 
 \ /
  Last update: 2018-12-06 10:34    [W:0.521 / U:10.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site