[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC] avoid indirect calls for DMA direct mappings
On Thu, Dec 06, 2018 at 08:24:38PM +0000, Robin Murphy wrote:
> On 06/12/2018 20:00, Christoph Hellwig wrote:
>> On Thu, Dec 06, 2018 at 06:54:17PM +0000, Robin Murphy wrote:
>>> I'm pretty sure we used to assign dummy_dma_ops explicitly to devices at
>>> the point we detected the ACPI properties are wrong - that shouldn't be too
>>> much of a headache to go back to.
>> Ok. I've cooked up a patch to use NULL as the go direct marker.
>> This cleans up a few things nicely, but also means we now need to
>> do the bypass scheme for all ops, not just the fast path. But we
>> probably should just move the slow path ops out of line anyway,
>> so I'm not worried about it. This has survived some very basic
>> testing on x86, and really needs to be cleaned up and split into
>> multiple patches..
> I've also just finished hacking something up to keep the arm64 status quo -
> I'll need to actually test it tomorrow, but the overall diff looks like the
> below.

Nice. I created a branch that picked up your bits and also the ideas
from Linus, and the result looks reall nice. I'll still need a signoff
for your bits, though.

Jesper, can you give this a spin if it changes the number even further?

git:// dma-direct-calls.2

 \ /
  Last update: 2018-12-07 02:22    [W:0.091 / U:5.580 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site