lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 05/11] livepatch: Simplify API by removing registration step
On Wed 2018-12-05 14:32:53, Joe Lawrence wrote:
> > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> > index 972520144713..e01dfa3b58d2 100644
> > --- a/kernel/livepatch/core.c
> > +++ b/kernel/livepatch/core.c
> > @@ -45,7 +45,7 @@
> > */
> > DEFINE_MUTEX(klp_mutex);
> >
> > -/* Registered patches */
> > +/* Actively used patches. */
> > LIST_HEAD(klp_patches);
>
> By itself, this comment makes me wonder if there are un-active and/or
> un-used patches that I need to worry about. After this patchset,
> klp_patches will include patches that have been enabled and those that
> have been replaced, but the replacement transition is still in progress.
>
> If that sounds accurate, how about adding to the comment:
>
> /* Actively used patches: enabled or replaced and awaiting transition */

The replaced patches are not in the list. This is why I used the word
"actively".

/*
* Actively used patches: enabled or in transition. Note that replaced
* or disabled patches are not listed even though the related kernel
* module still can be loaded.
*/

Best Regards,
Petr

\
 
 \ /
  Last update: 2018-12-06 09:29    [W:0.118 / U:28.696 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site