lkml.org 
[lkml]   [2018]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 -tip 0/7] tools/perf: Update rbtree implementation and optimize users
Date
Hi,

Per acme's request, this is a rebase (and basically rewrite) of v1.

The following optimizes the rb_first() lookups in perf tooling such that we
can avoid walking down the tree finding the first element. Tree traversals
(and overall computing the first node in the tree) is a surprisingly common
operation. On a Xeon E5-2450 @ 2.10GHz, the cost of an rb_first() was ~60 cycles
for 100 nodes, and ~75 cycles with 1000 nodes.

The first patch adds the updated implementation of rbtrees, including the
cached interfaces, taken from the kernel. The rest of the patches make use
of this for the users I thought might care the most.

With these patches I am able to build and use perf without anything going wrong
(but needs more testing no doubt, as changes while redundant can be a little tricky
depending on if the user get smart about the trees). I'm sorry if some patches
seem too big, I've tried to split them the best I could.

Applies on today's -tip tree. Please consider for v4.21.

Thanks!

Davidlohr Bueso (7):
tools/perf: Update rbtree implementation
perf machine: Use cached rbtrees
perf callchain: Use cached rbtrees
perf util: Use cached rbtree for rblists
perf symbols: Use cached rbtrees
perf hist: Use cached rbtrees
perf sched: Use cached rbtrees

tools/include/linux/rbtree.h | 52 ++++++++-
tools/include/linux/rbtree_augmented.h | 60 ++++++++--
tools/lib/rbtree.c | 178 ++++++++++++++++++++++-------
tools/perf/builtin-annotate.c | 4 +-
tools/perf/builtin-c2c.c | 6 +-
tools/perf/builtin-diff.c | 10 +-
tools/perf/builtin-report.c | 3 +-
tools/perf/builtin-sched.c | 45 ++++----
tools/perf/builtin-top.c | 2 +-
tools/perf/tests/hists_common.c | 8 +-
tools/perf/tests/hists_cumulate.c | 14 +--
tools/perf/tests/hists_link.c | 8 +-
tools/perf/tests/hists_output.c | 32 +++---
tools/perf/ui/browsers/hists.c | 6 +-
tools/perf/ui/gtk/hists.c | 4 +-
tools/perf/ui/stdio/hist.c | 3 +-
tools/perf/util/build-id.c | 12 +-
tools/perf/util/dso.c | 8 +-
tools/perf/util/dso.h | 10 +-
tools/perf/util/hist.c | 199 +++++++++++++++++++--------------
tools/perf/util/hist.h | 10 +-
tools/perf/util/intlist.h | 2 +-
tools/perf/util/machine.c | 53 +++++----
tools/perf/util/machine.h | 12 +-
tools/perf/util/map.c | 8 +-
tools/perf/util/metricgroup.c | 2 +-
tools/perf/util/probe-event.c | 3 +-
tools/perf/util/rb_resort.h | 8 +-
tools/perf/util/rblist.c | 28 +++--
tools/perf/util/rblist.h | 2 +-
tools/perf/util/sort.h | 4 +-
tools/perf/util/srcline.c | 43 ++++---
tools/perf/util/srcline.h | 13 ++-
tools/perf/util/stat-shadow.c | 2 +-
tools/perf/util/strlist.h | 2 +-
tools/perf/util/symbol.c | 87 +++++++-------
tools/perf/util/symbol.h | 13 ++-
tools/perf/util/symbol_fprintf.c | 2 +-
38 files changed, 598 insertions(+), 360 deletions(-)

--
2.16.4

\
 
 \ /
  Last update: 2018-12-06 20:19    [W:0.039 / U:0.824 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site