Messages in this thread | | | Subject | Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set performance state | From | Rajendra Nayak <> | Date | Wed, 5 Dec 2018 15:41:22 +0530 |
| |
On 12/5/2018 12:33 PM, Rajendra Nayak wrote: >> >>> + return 0; >>> + } >>> + >>> + of_node_put(np); >> >> This same code exists twice. Perhaps a helper needs to exist for >> qcom_rpm_get_performance() to pull the number out of the DT. > > Sure I can make both drivers use a common helper instead of duplicating it.
which would mean I will need to create a new file just to define the common helper. Does that seem like an overkill?
| |