lkml.org 
[lkml]   [2018]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 26/45] KVM: x86: fix empty-body warnings
    Date
    From: Yi Wang <wang.yi59@zte.com.cn>

    [ Upstream commit 354cb410d87314e2eda344feea84809e4261570a ]

    We get the following warnings about empty statements when building
    with 'W=1':

    arch/x86/kvm/lapic.c:632:53: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    arch/x86/kvm/lapic.c:1907:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    arch/x86/kvm/lapic.c:1936:65: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    arch/x86/kvm/lapic.c:1975:44: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

    Rework the debug helper macro to get rid of these warnings.

    Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/kvm/lapic.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
    index 69a81a7daa24..c8630569e392 100644
    --- a/arch/x86/kvm/lapic.c
    +++ b/arch/x86/kvm/lapic.c
    @@ -57,7 +57,7 @@
    #define APIC_BUS_CYCLE_NS 1

    /* #define apic_debug(fmt,arg...) printk(KERN_WARNING fmt,##arg) */
    -#define apic_debug(fmt, arg...)
    +#define apic_debug(fmt, arg...) do {} while (0)

    /* 14 is the version for Xeon and Pentium 8.4.8*/
    #define APIC_VERSION (0x14UL | ((KVM_APIC_LVT_NUM - 1) << 16))
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-12-05 11:00    [W:4.098 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site