lkml.org 
[lkml]   [2018]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"
Date
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

> This reverts commit 712ff25450bd01366301eef81c33e865d901e7b7.
> The output of dmi_save_uuid() is exposed to user space as
> /sys/devices/virtual/dmi/id/*_uuid, so this breaks backwards compatibility,
> E.G. I have systems that include the content of dmi/id/product_uuid as part
> of the keyphrase for cryptsetup luksOpen.

> As the change was purely cosmetical, revert it to fix such breakage.

> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Sorry, this should have had a:

Cc: stable@vger.kernel.org

As 4.19 is affected. Jean, can you add that when committing?


> ---
> drivers/firmware/dmi_scan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index 099d83e4e910..2ed51651565f 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -211,9 +211,9 @@ static void __init dmi_save_uuid(const struct dmi_header *dm, int slot,
> * says that this is the defacto standard.
> */
> if (dmi_ver >= 0x020600)
> - sprintf(s, "%pUl", d);
> + sprintf(s, "%pUL", d);
> else
> - sprintf(s, "%pUb", d);
> + sprintf(s, "%pUB", d);

> dmi_ident[slot] = s;
> }
> --
> 2.11.0


--
Bye, Peter Korsgaard

\
 
 \ /
  Last update: 2018-12-05 22:37    [W:0.058 / U:2.436 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site