[lkml]   [2018]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 1/2] drm: Only #define DEBUG if CONFIG_DYNAMIC_DEBUG is disabled
From: Michel Dänzer <>

The following cases are possible for pr_debug():

a) DEBUG not defined: pr_debug() translates to no_printk(...), i.e.
it never generates any output.
b) DEBUG defined: pr_debug() translates to printk(KERN_DEBUG ...),
i.e. it generates output which doesn't appear in dmesg by default,
can be enabled dynamically.

2. CONFIG_DYNAMIC_DEBUG enabled: pr_debug() translates to
a) DEBUG not defined: dynamic_pr_debug() generates no output by
default, can be enabled dynamically.
b) DEBUG defined: dynamic_pr_debug() generates output by default,
can be disabled dynamically.

The intention for drm_debug_printer() is to generate output which
doesn't appear in dmesg by default, but can be enabled dynamically, i.e.
cases 1b) and 2a). However, defining DEBUG unconditionally gave us 2b)
instead of 2a) with CONFIG_DYNAMIC_DEBUG enabled.

Fixes: 79a5ad2fdb3c ("drm: Enable pr_debug() for drm_printer")
Signed-off-by: Michel Dänzer <>
drivers/gpu/drm/drm_print.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index 0e7fc3e7dfb4..ee56e4a1b343 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -23,11 +23,13 @@
* Rob Clark <>

-#define DEBUG /* for pr_debug() */
#include <stdarg.h>
#include <linux/seq_file.h>
#include <drm/drmP.h>
+#define DEBUG /* for pr_debug() */
#include <drm/drm_print.h>

void __drm_puts_coredump(struct drm_printer *p, const char *str)
 \ /
  Last update: 2018-12-05 18:02    [W:0.103 / U:3.628 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site