lkml.org 
[lkml]   [2018]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/7] microblaze: fix race condition in building boot images
    From
    Date
    On 03. 12. 18 8:50, Masahiro Yamada wrote:
    > I fixed a race condition in the parallel building of ARM in commit
    > 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not
    > generate invalid images").
    >
    > I see the same problem for MicroBlaze too.
    >
    > "make -j<N> ARCH=microblaze all linux.bin.ub" results in a broken build
    > since two threads descend into arch/microblaze/boot simultaneously.

    I see also different problem that when I run that make above
    linux.bin.ub is not generated at all.


    >
    > Add proper dependencies to avoid it.
    >
    > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    > ---
    >
    > arch/microblaze/Makefile | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
    > index 7a5df02..544796d 100644
    > --- a/arch/microblaze/Makefile
    > +++ b/arch/microblaze/Makefile
    > @@ -79,13 +79,15 @@ all: linux.bin
    > archclean:
    > $(Q)$(MAKE) $(clean)=$(boot)
    >
    > +linux.bin.ub linux.bin.gz: linux.bin
    > +
    > PHONY += linux.bin linux.bin.gz linux.bin.ub
    > linux.bin linux.bin.gz linux.bin.ub: vmlinux
    > $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
    > @echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
    >
    > PHONY += simpleImage.$(DTB)
    > -simpleImage.$(DTB): vmlinux
    > +simpleImage.$(DTB): linux.bin.ub

    It looks weird that simpleImage requires linux.bin.ub.
    Is it really linux.bin.ub here or just linux.bin?

    > $(Q)$(MAKE) $(build)=$(boot) simple_images
    > @echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')'
    >
    >


    Thanks,
    Michal

    --
    Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
    w: www.monstr.eu p: +42-0-721842854
    Maintainer of Linux kernel - Xilinx Microblaze
    Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
    U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2018-12-05 17:32    [W:4.180 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site