Messages in this thread | | | Subject | Re: [PATCH 2/4] dma-debug: Refactor dma_debug_entry allocation | From | Robin Murphy <> | Date | Tue, 4 Dec 2018 16:09:30 +0000 |
| |
On 04/12/2018 14:27, Christoph Hellwig wrote: > On Mon, Dec 03, 2018 at 05:28:07PM +0000, Robin Murphy wrote: >> Make prealloc_memory() a little more general and robust so that it >> serves for runtime reallocations too. The first thing we can do with >> that is clean up dma_debug_resize_entries() quite a bit. > > Maybe also renamed it to dma_debug_alloc_entries or something like > that?
Yes, that's definitely nicer.
> Otherwise this looks fine to me.
Thanks (and for the review on #1)
Robin.
| |