Messages in this thread | | | From | Ulf Hansson <> | Date | Tue, 4 Dec 2018 15:19:48 +0100 | Subject | Re: [PATCH v1 1/1] mmc: core: control EXT_CSD_CACHE_CTRL from device tree |
| |
On Tue, 20 Nov 2018 at 21:06, Liming Sun <lsun@mellanox.com> wrote: > > Currently the EXT_CSD_CACHE_CTRL register is controlled by API > mmc_card_broken_hpi(), which only works for the quirks settings. > This commit enhances it to use card->ext_csd.hpi instead. This > flag works for both the quirks and the broken-hpi configuration > in the device tree. > > Signed-off-by: Liming Sun <lsun@mellanox.com>
I realize that the code around the HPI support needs some additional love. Let me post some patches in a day or two, then you can have a look a let me know your thoughts.
> --- > drivers/mmc/core/mmc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index bc1bd2c..2f2b65c 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -1791,8 +1791,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, > * If cache size is higher than 0, this indicates > * the existence of cache and it can be turned on. > */ > - if (!mmc_card_broken_hpi(card) && > - card->ext_csd.cache_size > 0) { > + if (card->ext_csd.hpi && card->ext_csd.cache_size > 0) {
Actually, I don't see a reason to why we should limit to use the cache, to whether HPI is supported or not.
I guess the thinking behind this, was that we wanted an option to abort the cache flush as there is no timeout available for that operation. However, I don't see whenever we should allow a cache flush to be aborted, as it would introduce a potential option of getting corrupt data on the flash.
> err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, > EXT_CSD_CACHE_CTRL, 1, > card->ext_csd.generic_cmd6_time); > -- > 1.8.3.1 >
Kind regards Uffe
| |