lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 043/146] btrfs: tree-checker: Fix misleading group system information
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    commit 761333f2f50ccc887aa9957ae829300262c0d15b upstream.

    block_group_err shows the group system as a decimal value with a '0x'
    prefix, which is somewhat misleading.

    Fix it to print hexadecimal, as was intended.

    Fixes: fce466eab7ac6 ("btrfs: tree-checker: Verify block_group_item")
    Reviewed-by: Nikolay Borisov <nborisov@suse.com>
    Reviewed-by: Qu Wenruo <wqu@suse.com>
    Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/tree-checker.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
    index fa8f64119e6f..f206aec1525d 100644
    --- a/fs/btrfs/tree-checker.c
    +++ b/fs/btrfs/tree-checker.c
    @@ -399,7 +399,7 @@ static int check_block_group_item(struct btrfs_fs_info *fs_info,
    type != (BTRFS_BLOCK_GROUP_METADATA |
    BTRFS_BLOCK_GROUP_DATA)) {
    block_group_err(fs_info, leaf, slot,
    -"invalid type, have 0x%llx (%lu bits set) expect either 0x%llx, 0x%llx, 0x%llu or 0x%llx",
    +"invalid type, have 0x%llx (%lu bits set) expect either 0x%llx, 0x%llx, 0x%llx or 0x%llx",
    type, hweight64(type),
    BTRFS_BLOCK_GROUP_DATA, BTRFS_BLOCK_GROUP_METADATA,
    BTRFS_BLOCK_GROUP_SYSTEM,
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-12-04 12:22    [W:4.067 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site