lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Uprobes: Fix kernel oops with delayed_uprobe_remove()
On Mon, 3 Dec 2018 11:52:41 +0530
Ravi Bangoria <ravi.bangoria@linux.ibm.com> wrote:

> Hi Steve,
>
> Please pull this patch.
>

Please send a v2 version of the patch with the updated change log. And
should it have a Fixes and be tagged for stable?

-- Steve

> Thanks.
>
> On 11/15/18 6:13 PM, Oleg Nesterov wrote:
> > On 11/15, Ravi Bangoria wrote:
> >>
> >> There could be a race between task exit and probe unregister:
> >>
> >> exit_mm()
> >> mmput()
> >> __mmput() uprobe_unregister()
> >> uprobe_clear_state() put_uprobe()
> >> delayed_uprobe_remove() delayed_uprobe_remove()
> >>
> >> put_uprobe() is calling delayed_uprobe_remove() without taking
> >> delayed_uprobe_lock and thus the race sometimes results in a
> >> kernel crash. Fix this by taking delayed_uprobe_lock before
> >> calling delayed_uprobe_remove() from put_uprobe().
> >>
> >> Detailed crash log can be found at:
> >> https://lkml.org/lkml/2018/11/1/1244
> >
> > Thanks, looks good,
> >
> > Oleg.
> >

\
 
 \ /
  Last update: 2018-12-04 06:59    [W:0.110 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site