lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] printk: Add caller information to printk() output.
    From
    Date
    On 2018/12/04 11:02, Sergey Senozhatsky wrote:
    > On (12/02/18 20:23), Tetsuo Handa wrote:
    >>
    >> Some examples for console output:
    >>
    >> [ 0.919699]@T1 x86: Booting SMP configuration:
    >> [ 4.152681]@T271 Fusion MPT base driver 3.04.20
    >> [ 5.070470]@C0 random: fast init done
    >> [ 6.587900]@C3 random: crng init done
    >
    > This is hard to read. Let's have a fixed width space for from_id.

    Console might be only 80 columns. When we have to check from screen capture of
    crash, triggering needless newlines due to occupying columns more than needed
    will not be nice. Also, syzbot has file size limit for saving console output.
    Wasting with needless spaces increases possibility of loosing past lines.
    Given that said, do you still want to waste precious columns with spaces?

    >
    >> +config PRINTK_FROM
    >> + bool "Show caller information on printks"
    >> + depends on PRINTK
    >
    > Wasn't it supposed to also depend on DEBUG_AID_FOR_SYZBOT?

    CONFIG_DEBUG_AID_FOR_SYZBOT is currently linux-next only option.
    This feature will be useful for non-syzbot environments.

    \
     
     \ /
      Last update: 2018-12-04 11:18    [W:4.142 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site