Messages in this thread | | | From | Anders Roxell <> | Date | Tue, 4 Dec 2018 20:34:12 +0100 | Subject | Re: [PATCH] tracing: add cond_resched to ftrace_replace_code() |
| |
On Tue, 4 Dec 2018 at 20:29, Steven Rostedt <rostedt@goodmis.org> wrote: > > On Tue, 4 Dec 2018 20:25:31 +0100 > Anders Roxell <anders.roxell@linaro.org> wrote: > > > On Tue, 4 Dec 2018 at 20:21, Steven Rostedt <rostedt@goodmis.org> wrote: > > > > > > On Tue, 4 Dec 2018 14:19:08 -0500 > > > Steven Rostedt <rostedt@goodmis.org> wrote: > > > > > > > > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable) > > > > > /* Stop processing */ > > > > > return; > > > > > } > > > > > + /* > > > > > + * Some archs calls this function with interrupts or preemption > > > > > + * disabled. Howeve, other archs don't and this can cause a > > > > > > typo "However". But could you write it this way: > > > > > > "However, for other archs that can preempt, this can cause an > > > tremendous unneeded latency." > > > > > > > I'll fix this and move it up (where I added it in the first place but > > moved it) =) > > > > I also noticed a grammar issue: > > "Some archs call this function .."
I will fix that.
Cheers, Anders
| |