lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] tracing: add cond_resched to ftrace_replace_code()
On Tue, 4 Dec 2018 at 20:21, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 4 Dec 2018 14:19:08 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable)
> > > /* Stop processing */
> > > return;
> > > }
> > > + /*
> > > + * Some archs calls this function with interrupts or preemption
> > > + * disabled. Howeve, other archs don't and this can cause a
>
> typo "However". But could you write it this way:
>
> "However, for other archs that can preempt, this can cause an
> tremendous unneeded latency."
>

I'll fix this and move it up (where I added it in the first place but
moved it) =)

Cheers,
Anders

> Thanks!
>
> -- Steve
>
> > > + * tremendous unneeded latency.
> > > + */
> >
> > Actually, could you move the comment up where schedulable gets set?
> >
> > Thanks!
> >
> > -- Steve
> >
> > > + if (schedulable)
> > > + cond_resched();
> > > } while_for_each_ftrace_rec();
> > > }
> > >
> >
>

\
 
 \ /
  Last update: 2018-12-04 20:25    [W:0.030 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site