lkml.org 
[lkml]   [2018]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: fix infinity loop in update_blocked_averages

* Vincent Guittot <vincent.guittot@linaro.org> wrote:

> > Reported-by: Zhipeng Xie <xiezhipeng1@huawei.com>
> > Cc: Bin Li <huawei.libin@huawei.com>
> > Cc: <stable@vger.kernel.org> [4.10+]
> > Fixes: 9c2791f936ef (sched/fair: Fix hierarchical order in rq->leaf_cfs_rq_list)
>
> If it only happens in update_blocked_averages(), the del leaf has been added by:
> a9e7f6544b9c (sched/fair: Fix O(nr_cgroups) in load balance path)

So I think until we are confident in the proposed fixes, how about
applying Linus's patch that reverts a9e7f6544b9c and simplifies the list
manipulation?

That way we can re-introduce the O(nr_cgroups) optimization without
pressure.

I'll prepare a commit for sched/urgent that does this, please holler if
any of you disagrees!

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-12-30 13:04    [W:0.058 / U:34.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site