lkml.org 
[lkml]   [2018]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM
On Sun, 30 Dec 2018, James Bottomley wrote:

>
> That said, as has been pointed out, the current #ifdef has a failing
> corner case when both are modular (because the code should then be
> included). The runtime macro that correctly expresses this is
> IS_REACHABLE(CONFIG_NVRAM).
>

No, in the case of CONFIG_NVRAM=m, the conditional code is deliberately
excluded. This is discussed in the patch description. The convention on
PPC32 is that device drivers drop support for NVRAM in this situation.

I've adopted the PPC32 convention here because M68K drivers and PPC32
drivers have to co-exist (I'm thinking of valkyriefb, but there are other
examples).

--

> James
>
>

\
 
 \ /
  Last update: 2018-12-30 22:45    [W:0.061 / U:81.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site