Messages in this thread | | | Date | Mon, 3 Dec 2018 09:35:00 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH] locktorture: Fix assignment of boolean variables |
| |
On Sat, Dec 01, 2018 at 12:37:01PM -0800, Paul E. McKenney wrote: > On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote: > > Fix the following warnings reported by coccinelle: > > > > kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:918:2-20: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:949:3-20: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:682:2-19: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:688:2-19: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:648:2-20: WARNING: Assignment of bool to 0/1 > > kernel/locking/locktorture.c:654:2-20: WARNING: Assignment of bool to 0/1 > > > > This patch also makes the code more readable. > > > > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> > > CC: Davidlohr Bueso <dave@stgolabs.net> > > CC: "Paul E. McKenney" <paulmck@linux.ibm.com> > > CC: Josh Triplett <josh@joshtriplett.org> > > CC: linux-kernel@vger.kernel.org > > Adding the current maintainers on CC.
So I strongly disagree with this. Anybody that has trouble with 0/1 vs false/true needs to stay the heck away from C.
I would suggest we delete that stupid coccinelle scripts that generates these pointless warns.
| |