Messages in this thread | | | Date | Fri, 28 Dec 2018 09:48:34 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr |
| |
On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote: > Follow the kernel conventions, rename addr_in_gen_pool to > gen_pool_has_addr.
Which convention? The old name certainly looks more sensible to me.
If we really want to change anything about this function I'd suggest to drop the size argument, as the address itself should describe the region good enough.
| |